Modify

Ticket #689 (closed task: fixed)

Opened 16 months ago

Last modified 15 months ago

Add subs selection to featured video

Reported by: and Owned by: mike
Priority: blocker Milestone: 4.3.1
Component: VideoPlayer Severity:
Keywords: Cc:
Who will test this: And

Description

This could be an EM only thing also if people think it's over engineering.

Attachments

Change History

comment:1 Changed 16 months ago by and

  • Priority changed from major to blocker

comment:2 Changed 16 months ago by anna

We discussed in our meeting we may not do this, as UniSubs? works using the URL, so making this work on the front page may not be easy.

It would be good to have a think about this though, even if we can't do it for this version, to if there is any way to get around this problem, as it would be great to feature the subtitling functionality on our front page.

In a blog listing on WP such as this the UniSubs? overlay shows up for multiple videos:  http://annahelme.com/tag/social-change/

I don't have subs on those videos so I don't know if they all work together..

But could displaying the <iframe> on the front page be a work-around...?

comment:3 Changed 16 months ago by mike

  • Status changed from new to closed
  • Resolution set to ready for testing

I've updated staging.

comment:4 Changed 16 months ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

Great! Works. The subtitles don't show up in a great position in the video frame. I suppose the player is too small for this to be optimised. We had a ticket earlier about making the player slightly bigger. This might solve the problem? Not sure if that wasn't possible for another reason though? If it is possible, that would be great. It does have a lot of white space around it, perhaps a quick CSS change could fix that?

comment:5 Changed 16 months ago by cpsaltis

  • Status changed from reopened to new
  • Owner set to Anna
  • Component changed from Architecture to VideoPlayer

I tried a few tweaks but if I make it a lot wider there is not much space for the description text on the left. There are only about 10px-20px I can squeeze out, but again there in no actual difference even if a reduce the font size.

I think this should be taken into account during the redesign. The featured video should be large enough for the subtitles.

comment:6 Changed 16 months ago by cpsaltis

  • Status changed from new to closed
  • Resolution set to ready for testing

comment:7 Changed 16 months ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

I just had a play with the CSS myself, yeah its a bit awkward, especially with the way the subtitles top-margin seems to work... generated by the UniSubs? player dynamically? I tried wrapping the text around the video-player but ran into other fiddly issues.

Maybe just quickly if we could change this in CSS to make the text sit better with the video player:

.feature { width: 260px; }

And also in the div for <!-- News and Events --> if you could give the <dd> tag a class of "featuredItem" that would be great. The page is a little jumbled at the moment, this would sort it out a little for the next month or more.

comment:8 Changed 16 months ago by cpsaltis

  • Status changed from reopened to new
  • Owner changed from Anna to mike

comment:9 Changed 16 months ago by mike

  • Status changed from new to closed
  • Resolution set to ready for testing

Done it on staging. Can you check it out and let me know if everything is ok?

comment:10 Changed 16 months ago by anna

Great this is fine for now. Let me know when its live on www.engagemedia.org and I'll check & tick off

comment:11 Changed 15 months ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

comment:12 Changed 15 months ago by mike

  • Status changed from reopened to closed
  • Resolution set to ready for testing

comment:13 Changed 15 months ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

great, done.

comment:14 Changed 15 months ago by anna

  • Status changed from reopened to closed
  • Resolution set to fixed
View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.